-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
descheduler: add a cache timeout argument for nodeAnomalyDetectors in lowNodeLoad plugin. #1955
Conversation
Signed-off-by: bogo <bogo.ysh@gmail.com>
Signed-off-by: bogo <bogo.ysh@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1955 +/- ##
==========================================
+ Coverage 67.52% 67.56% +0.04%
==========================================
Files 420 420
Lines 47040 47050 +10
==========================================
+ Hits 31764 31790 +26
+ Misses 12965 12951 -14
+ Partials 2311 2309 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign @eahydra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… lowNodeLoad plugin. (koordinator-sh#1955) Signed-off-by: bogo <bogo.ysh@gmail.com> Co-authored-by: zengwang1 <zengwang1@xiaomi.com>
… lowNodeLoad plugin. (koordinator-sh#1955) Signed-off-by: bogo <bogo.ysh@gmail.com> Co-authored-by: zengwang1 <zengwang1@xiaomi.com>
Ⅰ. Describe what this PR does
Now we have a constant timeout duration for the cache of anomalyDetectors. Perhaps we should make it be a parameter which easy to configure.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test